Fix GH-15179: Segmentation fault (null pointer dereference) in ext/standard/url_scanner_ex.re

Based on analysis by Ilija: https://github.com/php/php-src/issues/15179#issuecomment-2261546902

Fix GH-15179: Segmentation fault (null pointer dereference) in ext/standard/url_scanner_ex.re

Based on analysis by Ilija: https://github.com/php/php-src/issues/15179#issuecomment-2261546902

* Apply suggestions from code review

Closes GH-15206.

Co-authored-by: Ilija Tovilo <ilija.tovilo@me.com>

show more ...

Fix persistent local flag in session url updating (#13905)

Short-lived regression from 5ce9687cb2bc49e5d95b1c9bda5dc7f711c3da62.
I forgot to add the persistent local flag, so that means

Fix persistent local flag in session url updating (#13905)

Short-lived regression from 5ce9687cb2bc49e5d95b1c9bda5dc7f711c3da62.
I forgot to add the persistent local flag, so that means that RC_DEBUG
will complain. These strings are local to the thread so we can just add
the flag to silence the debug checker in this case.

show more ...

Fix GH-13891: memleak and segfault when using ini_set with session.trans_sid_hosts (#13892)

The hash tables used are allocated via the persistent allocator.
When using ini_set, the alloc

Fix GH-13891: memleak and segfault when using ini_set with session.trans_sid_hosts (#13892)

The hash tables used are allocated via the persistent allocator.
When using ini_set, the allocation happens via the non-persistent
allocator. When the table is then freed in GSHUTDOWN, we get a crash
because the allocators are mismatched.

As a side note, it is strange that this is designed this way, because it
means that ini_sets persist between requests...

Co-authored-by: Kamil Tekiela <tekiela246@gmail.com>

show more ...

Fix [-Wundef] warnings in standard extension

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as

Update http->https in license (#6945)

1. Update: http://www.php.net/license/3_01.txt to https, as there is anyway server header "Location:" to https.
2. Update few license 3.0 to 3.01 as 3.0 states "php 5.1.1, 4.1.1, and earlier".
3. In some license comments is "at through the world-wide-web" while most is without "at", so deleted.
4. fixed indentation in some files before |

show more ...

Add known strings for jit autoglobals

We always create interned strings for all autoglobals anyway, so
we might as well add known strings to make them more widely usable.

Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool

Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool is retained as an alias.

show more ...

Constify char * arguments of APIs

Closes GH-5676.

Add quiet parameter to internal HTML entities API

In some places, we need to make sure that no warnings are thrown
due to unknown encoding. The error reporting code tried to avoid
th

Add quiet parameter to internal HTML entities API

In some places, we need to make sure that no warnings are thrown
due to unknown encoding. The error reporting code tried to avoid
this by determining a "safe charset", but this introduces subtle
discrepancies in which charset is picked (normally
internal_encoding takes precedence). Avoid this by suppressing
the warning in the first place.

While here, use the fallback logic to print error messages with
substitution characters more consistently, to avoid skipping
parts of the error message entirely.

show more ...

Remove mention of PHP major version in Copyright headers

Closes GH-4732.

Use XtOffsetOf() in url_scanner_ex

Instead of a manual implementation.

Remove HAVE_LIMITS_H

The `<limits.h>` header file is part of the standard C89 headers [1]
and on current systems can be included unconditionally.

Since PHP requires at least C89

Remove HAVE_LIMITS_H

The `<limits.h>` header file is part of the standard C89 headers [1]
and on current systems can be included unconditionally.

Since PHP requires at least C89 or greater, the `HAVE_LIMITS_H` symbol
defined by Autoconf in configure.ac [2] can be ommitted and simplifed
however due to bundled file library (libmagic) and timelib still using
it, the removal there was omitted and done only in Zend.m4 file.

Current bundled libraries libtime, oniguruma, and libmagic still include
partial `HAVE_LIMITS_H` usage and will be more refactored when this is
possible.

Refs:
[1] https://port70.net/~nsz/c/c89/c89-draft.html#4.1.2
[2] https://git.savannah.gnu.org/cgit/autoconf.git/tree/lib/autoconf/headers.m4

show more ...

Remove legacy AC_CHECK_TYPE calls for uint and ulong

The AC_CHECK_TYPE was refactored in more recent versions of Autoconf
and the call with two arguments is obsolete and not recommended

Remove legacy AC_CHECK_TYPE calls for uint and ulong

The AC_CHECK_TYPE was refactored in more recent versions of Autoconf
and the call with two arguments is obsolete and not recommended anymore.

This patch also refactors some leftovers of using ulong and uint which
are not standard nor common usages of types in C.

The ulong can be used as zend_ulong and uint usage is actually
`unsigned int`.

The usage of HAVE_ULONG removed since it is not used in current code
base.

Legacy edgecase for some legacy HPUX systems removed:
- sys/stream.h header is not checked and the HAVE_SYS_STREAM_H is
not defined with current build system.

- flags are unsigned int
- max_allowed_packet changed to unsigned int

show more ...

Remove yearly range from copyright notice

Remove year range from copyright notice

Remove unused Git attributes ident

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
use

Remove unused Git attributes ident

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
user who changed it.

In Git this functionality is different and can be done with Git attribute
ident. These need to be defined manually for each file in the
.gitattributes file and are afterwards replaced with 40-character
hexadecimal blob object name which is based only on the particular file
contents.

This patch simplifies handling of $Id$ keywords by removing them since
they are not used anymore.

show more ...

Fix #76643: Segmentation fault when using `output_add_rewrite_var`

We have to check whether _SERVER is actually an array before we're
going to use it as such.

Use zend_string_release_ex() instread of zend_string_release() in places, where we sure about string persistence.

Fixed #74892 - Fixed URL rewriting for urls started with #

(cherry picked from commit 6c32d271d238a18cfc19d98877cdead1ab38f417)

This should have already been merged via
9cd82df0

Fixed #74892 - Fixed URL rewriting for urls started with #

(cherry picked from commit 6c32d271d238a18cfc19d98877cdead1ab38f417)

This should have already been merged via
9cd82df0bbb1f9a1407ffb749292576be1b91c07, but that merge went wrong.

show more ...

Fix some misspellings

year++

year++

year++

Added RC_DEBUG exception

Kill compiler warnings in ext/standard