PDO: Respect connection transaction state for dtor rollback

As mentioned in bug #80949, if a transaction is implicitly
committed, then PDO may still issue a ROLLBACK when the PDO
obj

PDO: Respect connection transaction state for dtor rollback

As mentioned in bug #80949, if a transaction is implicitly
committed, then PDO may still issue a ROLLBACK when the PDO
object is destroyed, as the transaction is still marked as active
in PDO's (inaccurate) transaction emulation.

Make sure we use the connection transaction state also for that
final ROLLBACK. A caveat here is that the connection might have
been dropped already, which may be the case for some drivers if
construction fails. Make sure we don't crash in that case.

show more ...

Add API to fetch bool value for PDO attribute values

Closes GH-6766

Validate string is numeric for integer PDO attribute value

Add comment explaining empty default case

Boolify pdo_dbh_attribute_set()

Boolify pdo_hash_methods()

Boolify pdo_stmt_describe_columns()

Use zend_objects_not_comparable in PDO

Generate class entries from stubs for oci8, odbc, openssl, pcntl, pdo, pgsql

Closes GH-6691

Refactor PDO's last inserted ID handler to use and return zend_string

Closes GH-6617

Refactor PDO doer handler to use zend_string

Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool

Replace zend_bool uses with bool

We're starting to see a mix between uses of zend_bool and bool.
Replace all usages with the standard bool type everywhere.

Of course, zend_bool is retained as an alias.

show more ...

Refactor PDO's quoter handler to return a zend_string

Closes GH-6547

Voidify PDO's fetch_error handler

Boolify PDO's transaction handlers

This includes begin(), commit(), rollBack(), and inTransaction()

Add/expand comments for PDO handlers

PDO: Store/pass query_string as zend_string

Rather than storing char* + size_t, use a zend_string*. Also
avoid various copies of the query string.

Merge branch 'PHP-8.0'

* PHP-8.0:
Allow drivers to omit error code

Allow drivers to omit error code

And thus generate error messages that match what PDO emulation
would generate.

This fixes the error message regression from the previous commit.

Merge branch 'PHP-8.0'

* PHP-8.0:
Fixed bug #66528

Merge branch 'PHP-7.4' into PHP-8.0

* PHP-7.4:
Fixed bug #66528

Fixed bug #66528

Report errors in commit, rollback and autocommit handlers.

Check for null dbh methods in get_gc

Methods may not be set at the point where get_gc is called. Fixes
a segfault in Laravel.

Merge branch 'PHP-8.0'

* PHP-8.0:
Fix inconsistency in PDO transaction state

Fix inconsistency in PDO transaction state

This addresses an issue introduced by #4996 and reported in
https://bugs.php.net/bug.php?id=80260.

Now that PDO::inTransaction() repor

Fix inconsistency in PDO transaction state

This addresses an issue introduced by #4996 and reported in
https://bugs.php.net/bug.php?id=80260.

Now that PDO::inTransaction() reports the real transaction state
of the connection, there may be a mismatch with PDOs internal
transaction state (in_tcx). This is compounded by the fact that
MySQL performs implicit commits for DDL queries.

This patch fixes the issue by making beginTransaction/commit/rollBack
work on the real transaction state provided by the driver as well
(or falling back to in_tcx if the driver does not support it).

This does mean that writing something like

$pdo->beginTransaction();
$pdo->exec('CREATE DATABASE ...');
$pdo->rollBack(); // <- illegal

will now result in an error, because the CREATE DATABASE already
committed the transaction. I believe this behavior is both correct
and desired -- otherwise, there is no indication that the code did
not behave correctly and the rollBack() was effectively ignored.
However, this is also a BC break.

Closes GH-6355.

show more ...