Fix [-Wlogical-op] in IMAP

Fix potential mail related segfault on Windows

`rpath` may be `NULL` here, in which case we must not access its
members.

Promote warnings to Error in IMAP extension

Drop some dependencies on argc at the same time

Closes GH-6164

Add proper default values for optional arguments in IMAP

Closes GH-6179

Refactor imap_mail()'s internal implementation to use zend_strings

Merge branch 'PHP-7.4' into master

* PHP-7.4:
Fix memory leak in php_imap_mutf7()

Merge branch 'PHP-7.3' into PHP-7.4

* PHP-7.3:
Fix memory leak in php_imap_mutf7()

Fix memory leak in php_imap_mutf7()

We have to free the string which has been allocated by libc-client.

Remove proto comments from C files

Closes GH-5758

Fix [-Wundef] warning in IMAP extension

Generate functions entries from stubs for another set of extensions

Closes GH-5351

Add stubs for aliases

Closes GH-5187

Make error messages more consistent by fixing capitalization

Closes GH-5066 As a first step, let's capitalize their initial letter when it is applicable.

Use RETURN_THROWS() after zend_fetch_resource*()

Use RETURN_THROWS() after try_convert_to_string()

Use RETURN_THROWS() during ZPP in most of the extensions

Except for some bigger ones: reflection, sodium, spl

Cleanup return values when parameter parsing is unsuccessful

Remove mention of PHP major version in Copyright headers

Closes GH-4732.

Added arginfo stubs for IMAP extension

Convert IMAP function aliases

These are not really aliases, convert them to normal functions.

Closes GH-4725.

Allow exceptions in __toString()

RFC: https://wiki.php.net/rfc/tostring_exceptions

And convert some object to string conversion related recoverable
fatal errors into Error excep

Allow exceptions in __toString()

RFC: https://wiki.php.net/rfc/tostring_exceptions

And convert some object to string conversion related recoverable
fatal errors into Error exceptions.

Improve exception safety of internal code performing string
conversions.

show more ...

Use release for regex in imap

The regex may be used as a cache key now.

Accept zend_string* instead of char* in php_pcre_match_impl()

Switch to use ZTS cache

Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly

Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly used by Vim and Emacs editors
yet with recent changes the once working definitions don't work
anymore in Vim without custom plugins or additional configuration.
Neither are these settings synced across the PHP code base.

A simpler and better approach is EditorConfig and fixing code
using some code style fixing tools in the future instead.

This patch also removes the so called modelines for Vim. Modelines
allow Vim editor specifically to set some editor configuration such as
syntax highlighting, indentation style and tab width to be set in the
first line or the last 5 lines per file basis. Since the php test
files have syntax highlighting already set in most editors properly and
EditorConfig takes care of the indentation settings, this patch removes
these as well for the Vim 6.0 and newer versions.

With the removal of local variables for certain editors such as
Emacs and Vim, the footer is also probably not needed anymore when
creating extensions using ext_skel.php script.

Additionally, Vim modelines for setting php syntax and some editor
settings has been removed from some *.phpt files. All these are
mostly not relevant for phpt files neither work properly in the
middle of the file.

show more ...