Refactor inheritance type check implementation

Extract the self/parent name resolution code and drop unnecessary
string copies/releases. Store the fe/proto types in local variables.

Deduplicate inheritance type check implementation

Make the check covariant (insofar as it is allowed now, i.e.
nullability and iterable) and call it with appropriate argument
order f

Deduplicate inheritance type check implementation

Make the check covariant (insofar as it is allowed now, i.e.
nullability and iterable) and call it with appropriate argument
order for both parameter and return types.

This makes it simpler to extend to full variance support.

show more ...

Fix resolution of "parent" during inheritance check

We can't assume that the method we're checking against is part of
the parent class...

Always generate fatal error for LSP failures

RFC: https://wiki.php.net/rfc/lsp_errors

Treat abstract ctors the same, regardless of origin

Abstract ctor signatures should always be respected by all children,
independently of whether it comes from an interface or an abstrac

Treat abstract ctors the same, regardless of origin

Abstract ctor signatures should always be respected by all children,
independently of whether it comes from an interface or an abstract
class. Previously abstract ctor signatures (if they didn't come from
an interface) were only checked to one level of inheritance.

show more ...

Fix lineno for more inheritance errors

And also include explicit linenos in tests.

Make line numbers for inheritance errors more precise

Use the line of the conflicting child method, rather than either the
first or last line of the class.

Fix typos in code comments in Zend/ [skip ci]

Avoid uninitialized entries in properties_info_table

Also don't place it into xlat, there's only ever one user.

Assign (un)serialize_func during compilation

This avoids writing this cache at runtime, which is illegal if
preloading is used.

Not every serialize/unserialize function actually

Assign (un)serialize_func during compilation

This avoids writing this cache at runtime, which is illegal if
preloading is used.

Not every serialize/unserialize function actually belongs to the
Serializable interface, but I think it's not a problem to assign
these anyway -- whether they are used ultimately depends on whether
Serializable is implemented.

Alternatively it might make sense to just drop these entirely. I
don't think this is performance critical functionality.

show more ...

Fixed bug #77613 (method visibility change) (reverted ZEND_ACC_CTOR and ZEND_ACC_DTOR flags removal)

Fix refcounting of prop types coming from traits

Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly

Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly used by Vim and Emacs editors
yet with recent changes the once working definitions don't work
anymore in Vim without custom plugins or additional configuration.
Neither are these settings synced across the PHP code base.

A simpler and better approach is EditorConfig and fixing code
using some code style fixing tools in the future instead.

This patch also removes the so called modelines for Vim. Modelines
allow Vim editor specifically to set some editor configuration such as
syntax highlighting, indentation style and tab width to be set in the
first line or the last 5 lines per file basis. Since the php test
files have syntax highlighting already set in most editors properly and
EditorConfig takes care of the indentation settings, this patch removes
these as well for the Vim 6.0 and newer versions.

With the removal of local variables for certain editors such as
Emacs and Vim, the footer is also probably not needed anymore when
creating extensions using ext_skel.php script.

Additionally, Vim modelines for setting php syntax and some editor
settings has been removed from some *.phpt files. All these are
mostly not relevant for phpt files neither work properly in the
middle of the file.

show more ...

Adios, yearly copyright ranges

Adios, yearly copyright ranges

Remove support for legacy constructors

This has been deprecated in PHP 7.0 by
https://wiki.php.net/rfc/remove_php4_constructors.

Fixed bug #77498

I've renamed the function to the same name as the exported symbol
in master.

Implement typed properties

RFC: https://wiki.php.net/rfc/typed_properties_v2

This is a squash of PR #3734, which is a squash of PR #3313.

Co-authored-by: Bob Weinand <bobwe

Implement typed properties

RFC: https://wiki.php.net/rfc/typed_properties_v2

This is a squash of PR #3734, which is a squash of PR #3313.

Co-authored-by: Bob Weinand <bobwei9@hotmail.com>
Co-authored-by: Joe Watkins <krakjoe@php.net>
Co-authored-by: Dmitry Stogov <dmitry@zend.com>

show more ...

Replace zend_hash_apply... with ZEND_HASH_FOREACH...

Fix #77291: magic methods inherited from a trait may be ignored

When adding methods from a trait, we must not assume that a method name
with the same length as the name of the using clas

Fix #77291: magic methods inherited from a trait may be ignored

When adding methods from a trait, we must not assume that a method name
with the same length as the name of the using class is either a PHP 4
style constructor, or not a magic method at all – it may well be
another magic method.

We mostly preserve the spirit of the optimization which caused this
regression, and avoid string comparisons for all method names which can
never be magic methods.

show more ...

Fixed issues related to optimization and persitence of classes linked with interfaces, traits or internal classes.

Future-proof email addresses

Update email addresses. We're still @Zend, but future proofing it...

Call function_add_ref() in proper place

Don't initialize static_member_tables during start-up, when inherit internal classes.