trailing whitespace removal

first shot remove TSRMLS_* things

Fixed bug #55541 errors spawn MessageBox, which blocks test automation

With that, also fixed bug #68297 (Application Popup provides too few
information) as a better error message is prov

Fixed bug #55541 errors spawn MessageBox, which blocks test automation

With that, also fixed bug #68297 (Application Popup provides too few
information) as a better error message is provided to the event log.

In the second case, the condition for display_startup_error was removed. The
condition was added as a fix for bug #30760 which was preventing the
MessageBox to appear. When display_startup_error=on, the error will be seen
on the console. But when running under a webserver it'll probably get lost,
so we need to log it other way into the event log (would be done automatically
when message box was used, but that would eventually cause issues of blocked
execution).

Generally speaking - any MessageBox or other graphical element is a potential
issue and that was repeatedly reported. Graphical elements shouldn't be used
in the core. Even being a rare one it can cause a bad situation where the
server is blocked. Yet some places have to cleaned up.

show more ...

typo fixes - https://github.com/vlajos/misspell_fixer

add missing type specifier

catch up with zend_html_puts

fix datatype mismatches and warnings

bring back all the TSRMLS_FETCH() stuff

for better comparability with the mainstream

Remove <% and <script language="php"> tags

As per https://wiki.php.net/rfc/remove_alternative_php_tags.

Removes:
* <% opening tag
* %> closing tag
* <%= short opening

Remove <% and <script language="php"> tags

As per https://wiki.php.net/rfc/remove_alternative_php_tags.

Removes:
* <% opening tag
* %> closing tag
* <%= short opening tag
* /<script\s+language\s*=\s*(php|"php"|'php')\s*>/i opening tag
* /</script>/i closing tag
* asp_tags ini directive

show more ...

some cleanups for TSRMLS_FETCH and direct tsrm_ls usage in main

reworked the patch, less new stuff but worky

TLS is already used in TSRM, the way exporting the tsrm cache through
a thread local variable is not portable. Additionally, the current

reworked the patch, less new stuff but worky

TLS is already used in TSRM, the way exporting the tsrm cache through
a thread local variable is not portable. Additionally, the current
patch suffers from bugs which are hard to find, but prevent it to
be worky with apache. What is done here is mainly uses the idea
from the RFC patch, but

- __thread variable is removed
- offset math and declarations are removed
- extra macros and definitions are removed

What is done merely is

- use an inline function to access the tsrm cache. The function uses
the portable tsrm_tls_get macro which is cheap
- all the TSRM_* macros are set to placebo. Thus this opens the way
remove them later

Except that, the logic is old. TSRMLS_FETCH will have to be done once
per thread, then tsrm_get_ls_cache() can be used. Things seeming to be
worky are cli, cli server and apache. I also tried to enable bz2
shared and it has worked out of the box. The change is yet minimal
diffing to the current master bus is a worky start, IMHO. Though will
have to recheck the other previously done SAPIs - embed and cgi.

The offsets can be added to the tsrm_resource_type struct, then
it'll not be needed to declare them in the userspace. Even the
"done" member type can be changed to int16 or smaller, then adding
the offset as int16 will not change the struct size. As well on the
todo might be removing the hashed storage, thread_id != thread_id and
linked list logic in favour of the explicit TLS operations.

show more ...

native tls initial patch

s/PHP 5/PHP 7/

fix printf format

Fix a number of format issues

Revert "Fix bug #67644 - Memory corruption & crash during ob_start function callback"

This reverts commit 53fa6c5b6b5b09059ba54c8912d0c0aef57aa4ff.
The change breaks tests, so not puttin

Revert "Fix bug #67644 - Memory corruption & crash during ob_start function callback"

This reverts commit 53fa6c5b6b5b09059ba54c8912d0c0aef57aa4ff.
The change breaks tests, so not putting it into 5.4.

show more ...

Fix bug #67644 - Memory corruption & crash during ob_start function callback

Fixed memory leaks

Refactored INI subsystem to use zend_string* instead of char*

several signature and data type fixes

master renamings phase 5

master renames phase 3

master renames phase 2

master renames phase 1

fix set_time_limit, substr and some more