Merge branch 'PHP-7.4'

* PHP-7.4:
zip edxtension is now 1.15.5
fix type consistency after 8f897f1040f00210f4a5cdd82a88a1fe3e558955

fix type consistency after
8f897f1040f00210f4a5cdd82a88a1fe3e558955

Merge branch 'PHP-7.4'

* PHP-7.4:
Replace deprecated libzip functions

Replace deprecated libzip functions

We replace all deprecated libzip functions with their recommended
substitutes, and add proper comment length checks including a test
case.

Merge branch 'PHP-7.4'

* PHP-7.4:
Remove dead code

Remove dead code

Added zip arginfo stubs

Add do...while(0) for RETURN_* and ZVAL_* APIs

Closes GH-4255.

Merge branch 'PHP-7.4'

php_zip_pcre: Match pattern before stating for directories

For two reasons: First, it's generally cheaper to match a regex than
perform a stat (especially on Windows). Second, it will no

php_zip_pcre: Match pattern before stating for directories

For two reasons: First, it's generally cheaper to match a regex than
perform a stat (especially on Windows). Second, it will not fail on
concurrent modification of a directory in parts that are not matched
by the pattern, such as the spurious failure in ext/zip/tests/bug72660.phpt.

show more ...

Cheaper checks for exceptions thrown from __toString()

Allow exceptions in __toString()

RFC: https://wiki.php.net/rfc/tostring_exceptions

And convert some object to string conversion related recoverable
fatal errors into Error excep

Allow exceptions in __toString()

RFC: https://wiki.php.net/rfc/tostring_exceptions

And convert some object to string conversion related recoverable
fatal errors into Error exceptions.

Improve exception safety of internal code performing string
conversions.

show more ...

Use ZEND_TRY_ASSIGN_REF_... macros for arguments passed to internal function by reference

Use ZEND_TRY_ASSIGN_REF_... macros for arguments passed to internal function by reference

Use ZEND_TRA_ASSIGN_REF_... macros for by reference arguments of internal functions.

Merge branch 'PHP-7.4'

* PHP-7.4:
Remove HAVE_* for always available extensions

Remove HAVE_* for always available extensions

Merge branch 'PHP-7.4'

* PHP-7.4:
Remove unused variables

Remove unused variables

Refactor zend_object_handlers API to pass zend_object* and zend_string* insted of zval(s).

Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly

Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly used by Vim and Emacs editors
yet with recent changes the once working definitions don't work
anymore in Vim without custom plugins or additional configuration.
Neither are these settings synced across the PHP code base.

A simpler and better approach is EditorConfig and fixing code
using some code style fixing tools in the future instead.

This patch also removes the so called modelines for Vim. Modelines
allow Vim editor specifically to set some editor configuration such as
syntax highlighting, indentation style and tab width to be set in the
first line or the last 5 lines per file basis. Since the php test
files have syntax highlighting already set in most editors properly and
EditorConfig takes care of the indentation settings, this patch removes
these as well for the Vim 6.0 and newer versions.

With the removal of local variables for certain editors such as
Emacs and Vim, the footer is also probably not needed anymore when
creating extensions using ext_skel.php script.

Additionally, Vim modelines for setting php syntax and some editor
settings has been removed from some *.phpt files. All these are
mostly not relevant for phpt files neither work properly in the
middle of the file.

show more ...

Remove yearly range from copyright notice

Implement typed properties

RFC: https://wiki.php.net/rfc/typed_properties_v2

This is a squash of PR #3734, which is a squash of PR #3313.

Co-authored-by: Bob Weinand <bobwe

Implement typed properties

RFC: https://wiki.php.net/rfc/typed_properties_v2

This is a squash of PR #3734, which is a squash of PR #3313.

Co-authored-by: Bob Weinand <bobwei9@hotmail.com>
Co-authored-by: Joe Watkins <krakjoe@php.net>
Co-authored-by: Dmitry Stogov <dmitry@zend.com>

show more ...

Remove preg_options param from pcre_get_compiled_regex()

This parameter is always zero and not necessary to call pcre2_match.

I'm leaving the parameter behind on the _ex() variant,

Remove preg_options param from pcre_get_compiled_regex()

This parameter is always zero and not necessary to call pcre2_match.

I'm leaving the parameter behind on the _ex() variant, so the preg_flags
are still accessible in some way.

show more ...

Use ZEND_THIS macro to hide implementation details in extensions code.