Fised possible use-after-free

Merge zend_execute_data->called_scope into zend_execute_data->This.
"called_scope" made sense only for static method calls, for dynamic calls it was always equal to the class of $this.
Now EG

Merge zend_execute_data->called_scope into zend_execute_data->This.
"called_scope" made sense only for static method calls, for dynamic calls it was always equal to the class of $this.
Now EG(This) may store IS_OBJECT + $this or IS_UNUSED + "called_scope" (of course, "called_scope" may be NULL).
Some code might need to be adopted to support this change.
Checks (Z_OBJ(EX(This))) might need to be converted into (Z_TYPE(EX(This)) == IS_OBJECT).

show more ...

Flags ZEND_CALL_RELEASE_THIS and ZEND_CALL_CLOSURE should never be set together.
Closures keep responsibility for releasing $this theirselves.

Fix build

Merge branch 'PHP-7.0'

Fixed bug #71601 (finally block not executed after yield from)

Fix bug #69989

This should cover all the basic cycles. Anything further would
require scanning the call stack and live temporaries.

Support partial GC for unfinished generators

This doesn't cover everything yet, but should be a good start for
cycled in unfinished generators.

Fix dangling send target when using yield from

Also drop some unnecessary TRY_DELREFs -- leftovers from the days
when null was refcounted.

Crude generator GC for value/key/retval

These values remain live after the generator has been closed, so
they are particularly susceptible to leaking cycles.

Fix accidental zval_dtor() usage

Fixed bug #71297 (Memory leak with yield from)

bump year which is missed in rev 49493a2

Fixed bug #71013 (Incorrect exception handler with yield from)

Fixed bug causing exception not being thrown immediately into a generator yielding from an array

Fixed bug #70965 (yield from with a common iterator primes too much)

Fixed bug #70904 (yield from incorrectly marks valid generator as finished)

Remove superfluous branches

Set expectations in generator handling

Fix bogus traces with ReflectionGenerator::getTrace()

Mark error and exception functions as "cold" (Matt's idea)

Get rid of implicit type casting in GC_*() macros in Zend/zend_types.h.
This prevented compilation warnings and disclosed few incorrect usages in Zend/zend_vm_def.h and ext/dom/xpath.c.
Now e

Get rid of implicit type casting in GC_*() macros in Zend/zend_types.h.
This prevented compilation warnings and disclosed few incorrect usages in Zend/zend_vm_def.h and ext/dom/xpath.c.
Now explicit type casting may be required on call site.
This may break some C extension code, but it shoulfn't be a problem to add explicit casting.

show more ...

"This" is C++ keyword

Use NULL where possible for exception class

Matches usage of zend_throw_exception()/zend_throw_exception_ex().

Remove need to pass error level