Update GitHub Action workflows to `actions/checkout@v4`

Keep this up to date in all non-security-only branches, because the node.js
runtime for older versions might get deprecated in the

Update GitHub Action workflows to `actions/checkout@v4`

Keep this up to date in all non-security-only branches, because the node.js
runtime for older versions might get deprecated in the future and fixing this
for all branches at once is easier.

show more ...

PHP-8.1 is now for PHP 8.1.25-dev

[skip ci] Skip arginfo_zpp_mismatch on asan

These tests intermittently crash asan. It might be due to some function invoking
dl(), which is known to crash lsan. It might also be somethin

[skip ci] Skip arginfo_zpp_mismatch on asan

These tests intermittently crash asan. It might be due to some function invoking
dl(), which is known to crash lsan. It might also be something else, the version
of asan shipped with ubuntu 22.04 is flaky.

show more ...

Fix #52751: XPath processing-instruction() function is not supported.

Closes GH-12165.

Fix GH-11878: SQLite3 callback functions cause a memory leak with a callable array

In this test file, the free_obj handler is called with a refcount of 2,
caused by the fact we do a GC_A

Fix GH-11878: SQLite3 callback functions cause a memory leak with a callable array

In this test file, the free_obj handler is called with a refcount of 2,
caused by the fact we do a GC_ADDREF() to increase its refcount while
its refcount is still 1 because the Foo object hasn't been destroyed yet
(due to the cycle caused by the sqlite function callback).
Solve this by introducing a get_gc handler.

Closes GH-11881.

show more ...

Fixed tracing JIT support for CALLABLE_CONVERT (#12156)

Fix zend_separate_if_call_and_write for FUNC_ARGs

Fixes GH-12102
Closees GH-12140

ODBC unit tests shouldn't override odbc.ini location

`ext/odbc/tests/config.inc` overrides the INIs used for the ODBC driver
manager pointlessly. It's not pointing to some custom PHP tes

ODBC unit tests shouldn't override odbc.ini location

`ext/odbc/tests/config.inc` overrides the INIs used for the ODBC driver
manager pointlessly. It's not pointing to some custom PHP test suite
specific one, but the system one in `/etc/odbc(inst).ini`. Which
doesn't necessarily exist, on i.e. NixOS, MacPorts, etc.

Closes GH-12133

Signed-off-by: George Peter Banyard <girgias@php.net>

show more ...

Fix persistent procedural ODBC connections not getting closed

Like oci8, procedural ODBC uses an apply function on the hash list to
enumerate persistent connections and close the specifi

Fix persistent procedural ODBC connections not getting closed

Like oci8, procedural ODBC uses an apply function on the hash list to
enumerate persistent connections and close the specific one. However,
this function take zvals, not resources. However, it was getting casted
as such, causing it to interpret the pointer incorrectly. This could
have caused other issues, but mostly manifested as failing to close the
connection even fi it matched.

The function now takes a zval and gets the resource from that. In
addition, it also removes the cast of the function pointer and moves
casting to the function body, to avoid possible confusion like this in
refactors again. It also cleans up style and uses constants in the
function body.

Closes GH-12132

Signed-off-by: George Peter Banyard <girgias@php.net>

show more ...

Prevents double call to internal iterator rewind handler

Closes GH-12060

Signed-off-by: George Peter Banyard <girgias@php.net>

adds failing test case for #12060

Signed-off-by: George Peter Banyard <girgias@php.net>

Fixed uninitialized EX(opline) access (possible Zend/tests/gh12073.phpt crash)

Fix freeing of incompletely initialized closures

Addref to relevant fields before allocating any memory. Also only set/remove the
ZEND_ACC_HEAP_RT_CACHE flag after allocating memory.

Fix freeing of incompletely initialized closures

Addref to relevant fields before allocating any memory. Also only set/remove the
ZEND_ACC_HEAP_RT_CACHE flag after allocating memory.

Fixes GH-12073
Closes GH-12074

show more ...

[skip ci] Backport GA paths-ignore changes

[skip ci] Skip github actions when editing other ci files

Fixed bug GH-12020: intl_get_error_message() broken after MessageFormatter::formatMessage() fails

Passing NULL as the pointer to intl_error* will use the global error stack.
This is what

Fixed bug GH-12020: intl_get_error_message() broken after MessageFormatter::formatMessage() fails

Passing NULL as the pointer to intl_error* will use the global error stack.
This is what we need to do instead of pushing it onto the temporary format object that is released.

show more ...

Fix memory leak with failed SQLPrepare

Closes GH-12095

Signed-off-by: George Peter Banyard <girgias@php.net>

[skip ci] Fix borked xleak skip on <PHP-8.3

xleak in skipif was only added in PHP 8.3.

Increase run-tests.php timeout for asan

Closes GH-12087

Fix GH-11972: RecursiveCallbackFilterIterator regression in 8.1.18

When you do an assignment between two zvals (no, not zval*), you copy
all fields. This includes the additional u2 data.

Fix GH-11972: RecursiveCallbackFilterIterator regression in 8.1.18

When you do an assignment between two zvals (no, not zval*), you copy
all fields. This includes the additional u2 data. So that means for
example the Z_NEXT index gets copied, which in some cases can therefore
cause a cycle in zend_hash lookups.
Instead of doing an assignment, we should be doing a ZVAL_COPY (or
ZVAL_COPY_VALUE for non-refcounting cases). This avoids copying u2.

Closes GH-12086.

show more ...

Skip dl() tests on ASAN

Make unrepeatable tests retriable

This was an error in thinking on my side. The reason these tests are
unrepeatable is because --repeat executes the same request in the same process,

Make unrepeatable tests retriable

This was an error in thinking on my side. The reason these tests are
unrepeatable is because --repeat executes the same request in the same process,
and does not run the CLEAN section in between runs. This is not the case when
retrying tests.

We could potentially make CLEAN tests repeatable by including the CLEAN section
in the tested script. This does however not work for all tests (e.g. tests that
set open_basedir).

Closes GH-12072

show more ...

On riscv64 require libatomic if actually needed

clang and newer gcc releases support byte-sized atomic accesses on
riscv64 through inline builtins. In both cases the hard dependency on

On riscv64 require libatomic if actually needed

clang and newer gcc releases support byte-sized atomic accesses on
riscv64 through inline builtins. In both cases the hard dependency on
libatomic added by GH-11321 isn't useful.

Stop using AC_CHECK_LIB() which is too naive to notice that libatomic
isn't needed. Instead, PHP_CHECK_FUNC() will retry the check with -latomic
if required.

Closes GH-11790

show more ...

[skip ci] Fix trailing data in unserialize in soap test

Fix missing instantclient in CI

We should only pass the --with-pdo-oci and --with-oci8 flags if instantclient is
installed.

Closes GH-12066