Restore old namespace reconciliation behaviour

The xmlDOMWrapReconcileNamespaces method we used to fix the namespace
corruption issues in 8.1.21/8.2.8 caused regressions.
Primarily,

Restore old namespace reconciliation behaviour

The xmlDOMWrapReconcileNamespaces method we used to fix the namespace
corruption issues in 8.1.21/8.2.8 caused regressions.
Primarily, there is a similar corruption that the xmlReconciliateNs method
used to have in which a namespace is suddenly shifted
(SAML-Toolkits/php-saml#562) and the side-effect of removing redundant
namespaces causes problems when a specific serialization is required.

Closes GH-12308.

show more ...

Fix GH-11997: ctype_alnum 5 times slower in PHP 8.1 or greater

Currently, a common function is used where a function pointer gets
passed to check the character class type. If we instead

Fix GH-11997: ctype_alnum 5 times slower in PHP 8.1 or greater

Currently, a common function is used where a function pointer gets
passed to check the character class type. If we instead use a macro, the
macro version of these character class type checkers can be used. While
this gives only a minor speed-up for glibc-based systems, on Alpine this
gives a multi-facor speed-up

This is essentially a manual revert of dc80ea7e38.

Full discussion in GH-11997.

Closes GH-12300.

show more ...

Fix GH-12297: PHP Startup: Invalid library (maybe not a PHP library) 'mysqlnd.so' in Unknown on line

On some configurations, the COMPILE_DL_MYSQLND must come from config.h.
If it isn't s

Fix GH-12297: PHP Startup: Invalid library (maybe not a PHP library) 'mysqlnd.so' in Unknown on line

On some configurations, the COMPILE_DL_MYSQLND must come from config.h.
If it isn't set, the get_module function won't be exposed, resulting in
a failure when trying to load the library.
It's the same issue ext/fileinfo had a while back that was fixed in
b0ba368d5.

Closes GH-12299.

show more ...

Fix GH-12167 and GH-12169: Unable to get comment or processing instruction contents in SimpleXML

Closes GH-12289.

Fix GH-12190: stream_context_create with address and port at 0.

Prior to the 8.1 rewrite, inet_aton was used for ipv4 addresses
therefore addresses like `0` passed.
For the bindto's

Fix GH-12190: stream_context_create with address and port at 0.

Prior to the 8.1 rewrite, inet_aton was used for ipv4 addresses
therefore addresses like `0` passed.
For the bindto's case where both ip and port are set as such, we discard
the address binding.

Close GH-12195

show more ...

Fix GH-12273 - configure __builtin_cpu_init() check

__builtin_cpu_init() is documented as having a void return type. It happens to
return int on gcc, but is void on clang.

Clos

Fix GH-12273 - configure __builtin_cpu_init() check

__builtin_cpu_init() is documented as having a void return type. It happens to
return int on gcc, but is void on clang.

Close GH-122274

show more ...

Fix GH-12282: IntlDateFormatter::construct should throw an exception is the locale field has an invalid value.

Close GH-12282

support running testsuite with negative niceness (#11481)

* support running testsuite with negative niceness

a bug in the regex would break getNice() if the current niceness was neg

support running testsuite with negative niceness (#11481)

* support running testsuite with negative niceness

a bug in the regex would break getNice() if the current niceness was negative, which would make the whole test fail.

Previously:
this would fail:
time sudo nice --adjustment=-19 ./php run-tests.php -j$(nproc) -x --offline ext/standard/tests/general_functions/proc_nice_basic.phpt --color --show-all

and this would work:
time sudo ./php run-tests.php -j$(nproc) -x --offline ext/standard/tests/general_functions/proc_nice_basic.phpt --color --show-all

* Update ext/standard/tests/general_functions/proc_nice_basic.phpt

Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>

---------

Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>

show more ...

Fix getpriority test with negative return value

Negative return values are valid and denote higher priority.

https://man7.org/linux/man-pages/man2/setpriority.2.html

[ci skip] NEWS

Remove redundant whitespace

Fix memory leak when calling xml_parse_into_struct() twice

Closes GH-12254.

Fix return type of stub of xml_parse_into_struct()

Closes GH-12253.

Fix GH-12243, segfault on IntlDateFormatter::construct with dateType set to UDAT_PATTERN but not timeType.

udat_open expects its timeStyle's argument to be set to UDAT_PATTERN
when date

Fix GH-12243, segfault on IntlDateFormatter::construct with dateType set to UDAT_PATTERN but not timeType.

udat_open expects its timeStyle's argument to be set to UDAT_PATTERN
when dateStyle is, regardless if there an actual pattern or not.

Close GH-12245

show more ...

Fix GH-12215: Module entry being overwritten causes type errors in ext/dom (<= PHP 8.3)

When we try to load an extension multiple times, we still overwrite the
type, module number, and h

Fix GH-12215: Module entry being overwritten causes type errors in ext/dom (<= PHP 8.3)

When we try to load an extension multiple times, we still overwrite the
type, module number, and handle. If the module number is used to
indicate module boundaries (e.g. in reflection and in dom, see e.g.
dom_objects_set_class_ex), then all sorts of error can happen.

In the case of ext/dom, OP's error happens because the following
happens:
- The property handler is set up incorrectly in
dom_objects_set_class_ex() because the wrong module number is
specified. The class highest in the hierarchy is DOMNode, so the
property handler is incorrectly set to that of DOMNode instead of
DOMDocument.
- The documentElement property doesn't exist on DOMNode, it only exists
on DOMDocument, so it tries to read using zend_std_read_property().
As there is no user property called documentElement, that read
operation returns an undef value.
However, the type is still checked, resulting in the strange exception.

Closes GH-12219.

show more ...

Fix bug #55098: SimpleXML iteration produces infinite loop

Closes GH-12247.

Fix GH-11956: PCRE regular expressions with JIT enabled gives different result

The code in the attached test used to work correctly in PHP 8.0, but not
in 8.1+. This is because PHP 8.1+

Fix GH-11956: PCRE regular expressions with JIT enabled gives different result

The code in the attached test used to work correctly in PHP 8.0, but not
in 8.1+. This is because PHP 8.1+ uses a more modern version of pcre2
than PHP 8.0, and that pcre2 versions has a regression.

While upgrading pcre2lib seems to be only done for the master branch, it
is possible to backport upstream fixes to stable branches. This has been
already done in the past in for JIT regressions [1], so it is not
unprecedented.

We backport the upstream pcre2 fix [2].

[1] https://github.com/php/php-src/commit/788a701e222
[2] https://github.com/PCRE2Project/pcre2/pull/135

Closes GH-12108.

show more ...

Fix GH-12207 memory leak of doc blocks of static properties

When declaring the same static property with a doc block in a class and in a trait,
the doc block of the property in the class

Fix GH-12207 memory leak of doc blocks of static properties

When declaring the same static property with a doc block in a class and in a trait,
the doc block of the property in the class is leaked. While at it, possibly fix doc
comment for internal classes.

Close GH-12238

show more ...

Fix GH-12208: SimpleXML infinite loop when a cast is used inside a foreach

Closes GH-12229.

Fix GH-12223: Entity reference produces infinite loop in var_dump/print_r

Closes GH-12223.

Fix GH-12192: SimpleXML infinite loop when getName() is called within foreach

This happens because getName() resets the iterator to the start because
it overwrites the iterator data.

Fix GH-12192: SimpleXML infinite loop when getName() is called within foreach

This happens because getName() resets the iterator to the start because
it overwrites the iterator data.
We add a version of get_first_node that does not overwrite the iterator
data.

Closes GH-12193.

show more ...

Fix GH-12186: segfault copying/cloning a finalized HashContext

Closes GH-12186.
Closes GH-12187.

Upgrade to macOS 12 in CI

We get some mysterious failures on macOS on GA with no evident error. This is a
blind attempt to solve it. There are many similar reports but there's no clear

Upgrade to macOS 12 in CI

We get some mysterious failures on macOS on GA with no evident error. This is a
blind attempt to solve it. There are many similar reports but there's no clear
resolution.

https://github.com/actions/runner-images/issues/7509#issuecomment-1538294874

Closes GH-12210

show more ...

Fix GH-12170: Can't use xpath with comments in SimpleXML

Closes GH-12177.

[skip ci] Fix NEWS entry

Fix filter_var with callback and explicit REQUIRE_SCALAR

For some reason, FILTER_CALLBACK disables the FILTER_REQUIRE_SCALAR flag that is
normally set by default. While surprising, this

Fix filter_var with callback and explicit REQUIRE_SCALAR

For some reason, FILTER_CALLBACK disables the FILTER_REQUIRE_SCALAR flag that is
normally set by default. While surprising, this is not something we can change.

However, even specifying FILTER_REQUIRE_SCALAR explicitly does not corrently set
this flag. This is because FILTER_CALLBACK zeroes the flags after they have been
populated from the parameters.

We reverse the checks to make explicitly specifying the flag behave as expected.

Closes GH-12203

show more ...