Don't return false for empty string in soundex()

Return "0000" instead of false to have a consistent return type.
"0000" is already a possible return value if the string doesn't
cont

Don't return false for empty string in soundex()

Return "0000" instead of false to have a consistent return type.
"0000" is already a possible return value if the string doesn't
contain any letters, such as with soundex(" "). We can treat the
case of soundex("") exactly the same.

show more ...

http_build_query() cannot fail

Assert that ht is not null and make php_url_encode_hash_ex() return
void to clarify that this is an infallible function.

html_entity_decode() cannot fail

php_unescape_html_entities() never returns null, so this function
can never return false.

php_unescape_html_entities() probably should be failin

html_entity_decode() cannot fail

php_unescape_html_entities() never returns null, so this function
can never return false.

php_unescape_html_entities() probably should be failing with OOM
for the "overflow" case, but even if it did, it would not be
signalled through a false return value.

show more ...

Validate phonemes parameter of metaphone()

And thus avoid the false return value.

substr_compare() cannot return false

Check string bounds in strspn/strcspn

strspn/strcspn are string search functions, and as such should throw
ValueError on out-of-bounds offsets, just like strpos etc do.

substr_replace() cannot return false

Add support for `@implementation-alias` in stubs

Closes GH-6170

Change int parameter types to bool when the parameter behaves as bool

Closes GH-6148

Generate arginfos

Display types in stubs more uniformly

In preparation for generating method signatures for the manual.

This change gets rid of bogus false|null return types, a few unnecessary traili

Display types in stubs more uniformly

In preparation for generating method signatures for the manual.

This change gets rid of bogus false|null return types, a few unnecessary trailing backslashes, and settles on using ? when possible for nullable types.

show more ...

Promote a few remaining errors in ext/standard

Closes GH-6110

Update array parameter names for named parameters

* The array "subject" of a function gets called $array.

* Further parameters should be self-descriptive if used
as a named pa

Update array parameter names for named parameters

* The array "subject" of a function gets called $array.

* Further parameters should be self-descriptive if used
as a named parameter, and a full word, not an abbreviation.

* If there is a "bunch more arrays" variadic, it gets
called $arrays (because that's what was already there).

* A few functions have a variadic "a bunch more arrays,
and then a callable", and were already called $rest.
I left those as is and died a little inside.

* Any callable provided to an array function that acts
on the array is called $callback. (Nearly all were already,
I just fixed the one or two outliers.)

* array_multisort() is beyond help so I ran screaming.

show more ...

Declare array|int and object-of-class|int types in stubs

Closes GH-6081

Co-Authored-By: Nikita Popov <nikic@php.net>

Fix a few stub parameter types in ext/standard

Make array_multisort() signature more variadic

The second and third arguments are not always the sort_order and
sort_flags -- they can also be in reverse order, or be arrays
altogeth

Make array_multisort() signature more variadic

The second and third arguments are not always the sort_order and
sort_flags -- they can also be in reverse order, or be arrays
altogether. Move them into the variadic parameter to avoid awkward
error messages.

show more ...

Allow array_diff() and array_intersect() with single array argument

Both of these functions are well-defined when used with a single
array argument -- rejecting this case was an artifici

Allow array_diff() and array_intersect() with single array argument

Both of these functions are well-defined when used with a single
array argument -- rejecting this case was an artificial limitation.
This is not useful when called with explicit arguments, but removes
edge-cases when used with argument unpacking:

// OK even if $excludes is empty.
array_diff($array, ...$excludes);

// OK even if $arrays contains a single array only.
array_intersect(...$arrays);

This matches the behavior of functions like array_merge() and
array_push(), which also allow calls with no array or a single
array respectively.

Closes GH-6097.

show more ...

Improve error messages mentioning parameters instead of arguments

Closes GH-5999

Fix UNKNOWN default values in ext/standard

Closes GH-6026

Drop support for crypt() without explicit salt

crypt() without salt generates a weak $1$ MD5 hash. It has been
throwing a notice since 2013 and we provide a much better alternative
i

Drop support for crypt() without explicit salt

crypt() without salt generates a weak $1$ MD5 hash. It has been
throwing a notice since 2013 and we provide a much better alternative
in password_hash() (which can auto-generate salts for strong
password hashes), so keeping this is just a liability.

show more ...

Use ZPP instead of custom type checks

We can add these types as a native type declaration to stubs as a side-effect. Closes GH-6068

Fix more basic function stubs

User-defined functions can't have multiple parameters with the same name.
Don't do that for var_dump/debug_zval_dump.

Consistently use array $array

Fix more basic function stubs

User-defined functions can't have multiple parameters with the same name.
Don't do that for var_dump/debug_zval_dump.

Consistently use array $array to match docs

Fix typo in UPGRADING

Fixes GH-6015

show more ...

Use ZPP callable check for Windows specific functions

Fix param name in PHPDoc

Add all the missing parameter types to stubs

Closes GH-5955