Don't return false for empty string in soundex()

Return "0000" instead of false to have a consistent return type.
"0000" is already a possible return value if the string doesn't
cont

Don't return false for empty string in soundex()

Return "0000" instead of false to have a consistent return type.
"0000" is already a possible return value if the string doesn't
contain any letters, such as with soundex(" "). We can treat the
case of soundex("") exactly the same.

show more ...

http_build_query() cannot fail

Assert that ht is not null and make php_url_encode_hash_ex() return
void to clarify that this is an infallible function.

substr_replace() cannot return false

Return empty array for no rows in pg_fetch_all()

This makes it line up with pg_fetch_all_columns(), as well as
similar functions in other exts, such as mysqli_fetch_all().

Promote invalid field to ValueError in pgsql

The same error condition is a ValueError in mysqli, be consistent.

Additionally, do not display the argument name for these errors.

Promote invalid field to ValueError in pgsql

The same error condition is a ValueError in mysqli, be consistent.

Additionally, do not display the argument name for these errors.
As the signatures are overloaded, the argument name may not match
the meaning at all.

show more ...

pg_unescape_bytea() can only fail on OOM

The implementation did not check for PQunescapeBytea failure
correctly, because it checked for a null pointer after estrndup,
which certainly

pg_unescape_bytea() can only fail on OOM

The implementation did not check for PQunescapeBytea failure
correctly, because it checked for a null pointer after estrndup,
which certainly cannot happen. Inspection of the PGunescapeBytea
implementation has shown that this function can only fail on OOM,
so let's check for that explicitly and remove false as a possible
return type.

While we're here, avoid an unnecessary copy of the result.

show more ...

Add system ID entropy API

The `zend_system_id` is a (true global) system ID that fingerprints a process state. When extensions add engine hooks during MINIT/startup, entropy is added the sys

Add system ID entropy API

The `zend_system_id` is a (true global) system ID that fingerprints a process state. When extensions add engine hooks during MINIT/startup, entropy is added the system ID for each hook. This allows extensions to identify that changes have been made to the engine since the last PHP process restart.

Closes GH-5871

show more ...

Add some ValueErrors to ext/date

Closes GH-5613

Promote warnings to Error in MySQLi extension

Closes GH-5803

Promote a few remaining errors in ext/standard

Closes GH-6110

Promote warnings to Errors in PostgreSQL extension

Do some drive by indentation fixes
Also fix pg_select() in regards to the $result_type arg which was missing from ZPP

Closes G

Promote warnings to Errors in PostgreSQL extension

Do some drive by indentation fixes
Also fix pg_select() in regards to the $result_type arg which was missing from ZPP

Closes GH-6129

show more ...

More pgsql func info fixes

Fix opcache return type info for pgsql functions

Infer information about packed/hash arrays and use it for JIT

Promote warnings to exceptions in ext/gettext, ext/sysvmsg and ext/xml

Closes GH-5926

Prevent incorrect trasing JIT TSSA usage for range() result type inference

Fix arg/func info

* mysqli_get_server_info() cannot return null. The underlying API
is infallible.
* mysqli_select_db() func info is redundant.
* mb_detect_order() can only

Fix arg/func info

* mysqli_get_server_info() cannot return null. The underlying API
is infallible.
* mysqli_select_db() func info is redundant.
* mb_detect_order() can only return array|true, not array|false.

Also make the func_info.phpt test that is supposed to catch these
kinds of issues actually work.

show more ...

Check for redundant func info

Stricter verification of func info against arg info

Make sure they're actually the same up to cases where func info
allows more accurate expressions. There are some awkward edge cases

Stricter verification of func info against arg info

Make sure they're actually the same up to cases where func info
allows more accurate expressions. There are some awkward edge cases
around true/false/null limitations in union types.

show more ...

Remove some redundant func info

This is fully covered by arginfo.

The array_merge_recursive() RC information was also wrong,
it should be the same as array_merge().

Fix mb_ereg_search* arg and func info

Remove null from highlight_* return types

Also fix show_source() discrepancy in func_info.

Remove bool return type from assert_options

Not seeing any way this function can return bool.

Fix iptcembed func info

This function can return true with $spool >= 2.

Fixed pg_select() function info