#
bdeb220f |
| 13-Dec-2014 |
Anatol Belski |
first shot remove TSRMLS_* things
|
#
3893c1fc |
| 12-Dec-2014 |
Dmitry Stogov |
Fixed compilation warnings
|
#
3affc0e8 |
| 12-Dec-2014 |
Anatol Belski |
Fixed bug #68583 Crash in timeout thread This replaces the GUI element used for execution timeout handling on Windows. Instead a timer queue technique is used, which is indeed a thre
Fixed bug #68583 Crash in timeout thread This replaces the GUI element used for execution timeout handling on Windows. Instead a timer queue technique is used, which is indeed a thread pool. A timer queue timer is a lightweight object handled but that thread pool and the timer thread spends most of the time sleeping and waiting for an alert. Please note also that this introduces neither binary nor source breach. The custom timeout thread functions are deleted, however they was not exported throug DLL, so couldn't be used by any external code. As well they couldn't be used anywhere in the core except in executor api, because those custom timeout thread functions they used to operate on static variables which would be overwritten (and that would blow). So instead a relatively modern technique is used for the timeout handling. It's still not perfect because the executor still has to check EX(timed_out). This can be a topic for an improvement in master. But brobably can be tricky as currently it seems to be not possible to signal an individual thread. Also note another issue that static variables aren't thread safe, but the current timer implementation is.
show more ...
|
#
27dc5986 |
| 11-Dec-2014 |
Dmitry Stogov |
Moved zend_is_true() from zend_execute.h/zend_execute_API.c into zend_operators.h/zend_operators.c. Splited the most expensive part of inline i_zend_is_true() into a separate zend_object_is_true(
Moved zend_is_true() from zend_execute.h/zend_execute_API.c into zend_operators.h/zend_operators.c. Splited the most expensive part of inline i_zend_is_true() into a separate zend_object_is_true(). Replaced zendi_convert_to_long() with cals to zend_is_true().
show more ...
|
#
dcfe5877 |
| 28-Nov-2014 |
Dmitry Stogov |
Rename EX_VAR_2() into ZEND_CALL_VAR() and EX_VAR_NUM_2() into ZEND_CALL_VAR_NUM().
|
#
1da14c9f |
| 28-Nov-2014 |
Dmitry Stogov |
Pack EX(frame_info) into EX(This).u1.v.reserved. Rename "frame"kind" into "call_kind" and VM_FRAME_... into ZEND_CALL_...
|
#
11384ba7 |
| 28-Nov-2014 |
Dmitry Stogov |
Pack EX(num_args) into EX(This).u2.num_args
|
Revision tags: php-5.6.4RC1, php-5.5.20RC1 |
|
#
317d7c62 |
| 17-Nov-2014 |
Anatol Belski |
fix incompatible pointer types
|
#
873a460c |
| 17-Nov-2014 |
Anatol Belski |
fix incompatible pointer types
|
#
1504e9c9 |
| 17-Nov-2014 |
Anatol Belski |
fix incompatible pointer types
|
#
14ccac02 |
| 13-Nov-2014 |
Anatol Belski |
fix datatype mismatch
|
Revision tags: php-5.6.3, php-5.5.19, php-5.4.35 |
|
#
ab849392 |
| 10-Nov-2014 |
Xinchen Hui |
Fixed bug #68370 ("unset($this)" can make the program crash)
|
Revision tags: php-5.6.3RC1, php-5.5.19RC1 |
|
#
89ed34e3 |
| 24-Oct-2014 |
Anatol Belski |
fix datatype mismatches
|
#
7959e3fa |
| 22-Oct-2014 |
Anatol Belski |
fix datatype mismatches for strings from userspace
|
Revision tags: php-5.5.18 |
|
#
c00424e4 |
| 15-Oct-2014 |
Anatol Belski |
bring back all the TSRMLS_FETCH() stuff for better comparability with the mainstream
|
Revision tags: php-5.4.34 |
|
#
43f1c94d |
| 09-Oct-2014 |
Nikita Popov |
Review a few more SEPARATE_ZVAL_IF_NOT_REF usages
|
#
33e137d4 |
| 07-Oct-2014 |
Dmitry Stogov |
Merged EX(frame_kind) and EX(flags) into single word
|
#
9bc14f96 |
| 05-Oct-2014 |
Nikita Popov |
Fix dynamic calls to static methods with fci->object func may already be freed at the time the static flag was checked.
|
#
bd9a2346 |
| 03-Oct-2014 |
Dmitry Stogov |
Replaced EG(This) and EX(object) with EX(This). Internal functions now recieves zend_execute_data as the first argument.
|
Revision tags: php-5.5.18RC1, php-5.6.1 |
|
#
9f7564b1 |
| 01-Oct-2014 |
Dmitry Stogov |
Removed zend_execute_data->prev_nested_call. Reuse prev_execute_data instead.
|
#
06d0230a |
| 26-Sep-2014 |
Anatol Belski |
cleanup TSRMLS_FETCH
|
#
d11734b4 |
| 25-Sep-2014 |
Anatol Belski |
reworked the patch, less new stuff but worky TLS is already used in TSRM, the way exporting the tsrm cache through a thread local variable is not portable. Additionally, the current
reworked the patch, less new stuff but worky TLS is already used in TSRM, the way exporting the tsrm cache through a thread local variable is not portable. Additionally, the current patch suffers from bugs which are hard to find, but prevent it to be worky with apache. What is done here is mainly uses the idea from the RFC patch, but - __thread variable is removed - offset math and declarations are removed - extra macros and definitions are removed What is done merely is - use an inline function to access the tsrm cache. The function uses the portable tsrm_tls_get macro which is cheap - all the TSRM_* macros are set to placebo. Thus this opens the way remove them later Except that, the logic is old. TSRMLS_FETCH will have to be done once per thread, then tsrm_get_ls_cache() can be used. Things seeming to be worky are cli, cli server and apache. I also tried to enable bz2 shared and it has worked out of the box. The change is yet minimal diffing to the current master bus is a worky start, IMHO. Though will have to recheck the other previously done SAPIs - embed and cgi. The offsets can be added to the tsrm_resource_type struct, then it'll not be needed to declare them in the userspace. Even the "done" member type can be changed to int16 or smaller, then adding the offset as int16 will not change the struct size. As well on the todo might be removing the hashed storage, thread_id != thread_id and linked list logic in favour of the explicit TLS operations.
show more ...
|
#
70077d84 |
| 24-Sep-2014 |
Anatol Belski |
check che right thing to prevent the crash in the timeout thread Though this seems to be a dead end, the lines CG(timed_out) = 0; looks like will never be executed in the TS build. Or at
check che right thing to prevent the crash in the timeout thread Though this seems to be a dead end, the lines CG(timed_out) = 0; looks like will never be executed in the TS build. Or at least it'll be executed by luck when the scheduler has decided to let the master thread run for longer. NTS should be fine with that however.
show more ...
|
Revision tags: php-5.6.2 |
|
#
bccc6531 |
| 19-Sep-2014 |
Dmitry Stogov |
Avoid double IS_INTERNED() check
|
#
3bc8a958 |
| 19-Sep-2014 |
Dmitry Stogov |
Fixed useless or duplicated IS_INTERNED() checks
|