Fix expression warnings and break warnings

Close GH-5675.

Add Attributes

Co-authored-by: Martin Schröder <m.schroeder2007@gmail.com>

Make Exception::$trace typed array property

This is a private property, so we are allowed to add a type.
The new declaration of the property is:

private array $trace = [];

Make Exception::$trace typed array property

This is a private property, so we are allowed to add a type.
The new declaration of the property is:

private array $trace = [];

This ensures that Exception::getTrace() does indeed return an array.

Userland code that was modifying the property through refleciton
may have to be adjusted to assign an array (instead of null,
for example).

Closes GH-5636.

show more ...

Improve type error messages when an object is given

From now on, we always display the given object's type instead of just reporting "object".
Additionally, make the format of return typ

Improve type error messages when an object is given

From now on, we always display the given object's type instead of just reporting "object".
Additionally, make the format of return type errors match the format of argument errors.

Closes GH-5625

show more ...

Refactor ZPP API to use uint32_t as everywhere else

Closes GH-5609

Add support for the mixed type

RFC: https://wiki.php.net/rfc/mixed_type_v2
Closes GH-5313

Co-authored-by: Dan Ackroyd <danack@basereality.com>

Improve error messages for invalid property access

Closes GH-5446
Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>

Assert on unknown type in zend_get_type_by_const()

Rename zend_zval_get_type() API

We have a bunch of APIs for getting type names and it's sometimes
hard to keep them apart ... make it clear that this is the one
you definitely do not

Rename zend_zval_get_type() API

We have a bunch of APIs for getting type names and it's sometimes
hard to keep them apart ... make it clear that this is the one
you definitely do not want to use.

show more ...

Add Fast ZPP string|int type check

Completely remove disabled functions from function table

Currently, disabling a function only replaces the internal
function handler with one that throws a warning, and a few
places

Completely remove disabled functions from function table

Currently, disabling a function only replaces the internal
function handler with one that throws a warning, and a few
places in the engine special-case such functions, such as
function_exists. This leaves us with a Schrödinger's function,
which both does not exist (function_exists returns false) and
does exist (you cannot define a function with the same name).
In particular, this prevents the implementation of robust
polyfills, as reported in https://bugs.php.net/bug.php?id=79382:

if (!function_exists('getallheaders')) {
function getallheaders(...) { ... }
}

If getallheaders() is a disabled function, this code will break.

This patch changes disable_functions to remove the functions from
the function table completely. For all intents and purposes, it
will look like the function does not exist.

This also renders two bits of PHP functionality obsolete and thus
deprecated:

* ReflectionFunction::isDisabled(), as it will no longer be
possible to construct the ReflectionFunction of a disabled
function in the first place.
* get_defined_functions() with $exclude_disabled=false, as
get_defined_functions() now never returns disabled functions.

Fixed bug #79382.

Closes GH-5473.

show more ...

Remove redundant addref+dtor

Pass existing lcname to check_magic_method_implementation

Use zend_string in zend_check_magic_method implementation

Check Serialization magic methods structure

Closes GH-5441

Remove ZEND_ACC_DTOR flag

This is only used in reflection, where doing a simple string check
is acceptable.

I'm also dropping the "dtor" printing in the reflection dump.
Dto

Remove ZEND_ACC_DTOR flag

This is only used in reflection, where doing a simple string check
is acceptable.

I'm also dropping the "dtor" printing in the reflection dump.
Dtors are just one of many magic methods, I don't think there's
a point in explicitly highlighting them, when the name is already
unambiguous.

show more ...

Align magic methods' camelCase with documentation

Closes GH-5398

Add zend_string_concat2 API

Always use __invoke callable name for objects

The callable name is provided also if it's not callable, in which
case it's basically "what it would be if it were callable", which
is C

Always use __invoke callable name for objects

The callable name is provided also if it's not callable, in which
case it's basically "what it would be if it were callable", which
is ClassName::__invoke. The current behavior of casting the object
to string makes very little sense as this will just throw an
exception for most objects.

show more ...

Add zend_create_member_string() API

This is a recurring pattern.

Export the zend_string_concat3() API

Export API for fetching internal func default

Make this functionality available outside reflection.

Assert that arginfo parameter name is present

Display nullability in type error messages for internal functions

Closes GH-5327

Make cast_object handler required

Avoid subtle differences in behavior depending on whether the
handler is absent or returns FAILURE.

If you previously set cast_object to NULL,

Make cast_object handler required

Avoid subtle differences in behavior depending on whether the
handler is absent or returns FAILURE.

If you previously set cast_object to NULL, create a handler that
always returns FAILURE instead.

show more ...