Fix several mostly Windows related phpdbg bugs

* Properly initialize PHPDBG_G(watch_tmp)

Otherwise that may cause segfaults in ZTS builds.

* Deactivate potentially remain

Fix several mostly Windows related phpdbg bugs

* Properly initialize PHPDBG_G(watch_tmp)

Otherwise that may cause segfaults in ZTS builds.

* Deactivate potentially remaining watchpoints after REPL

Otherwise the memory could still be protected, resulting in segfaults
during shutdown.

* NULL zend_handlers_table after freeing

As of commit 4130fe4[1], the `zend_handlers_table` is explicitly
freed in the `zend_vm_dtor()`. Since phpdbg (and maybe some other
SAPIs) may restart the engine afterwards, we have to make sure that
the table is also NULLed.

* Only set context option if there is a context

In other words, we must not follow the null pointer.

* Cater to file handles without attached console

File handles do not necessarily have an attached console (for
instance, pipes do not), in which case `GetConsoleScreenBufferInfo()`
fails. In this case we set a default value (`40`) for lines like on
other systems.

[1] <http://git.php.net/?p=php-src.git;a=commit;h=4130fe437a5db7ead1444d3748bd0fbad9829cb2>

show more ...

Fix INI setting member name

Since the member is not used in `OnUpdateEol()` that's not really an
issue, but still it's confusing to apparently have two INI settings
targeting the sam

Fix INI setting member name

Since the member is not used in `OnUpdateEol()` that's not really an
issue, but still it's confusing to apparently have two INI settings
targeting the same member.

show more ...

Fix symtable_cache_limit assignment in phpdbg

The meaning of the limit changed in 7.4, it now points one past the
end. Adjust code accordingly.

Report errors from stream read and write operations

The php_stream_read() and php_stream_write() functions now return
an ssize_t value, with negative results indicating failure. Function

Report errors from stream read and write operations

The php_stream_read() and php_stream_write() functions now return
an ssize_t value, with negative results indicating failure. Functions
like fread() and fwrite() will return false in that case.

As a special case, EWOULDBLOCK and EAGAIN on non-blocking streams
should not be regarded as error conditions, and be reported as
successful zero-length reads/writes instead. The handling of EINTR
remains unclear and is internally inconsistent (e.g. some code-paths
will automatically retry on EINTR, while some won't).

I'm landing this now to make sure the stream wrapper ops API changes
make it into 7.4 -- however, if the user-facing changes turn out to
be problematic we have the option of clamping negative returns to
zero in php_stream_read() and php_stream_write() to restore the
old behavior in a relatively non-intrusive manner.

show more ...

Initialize last_line in phpdbg globals

Avoid reliance on arena details on phpdbg oplog

Instead of guessing what the address of the first arena allocation
is going to be, embed the sentinel in the oplog_list structure
dire

Avoid reliance on arena details on phpdbg oplog

Instead of guessing what the address of the first arena allocation
is going to be, embed the sentinel in the oplog_list structure
directly.

show more ...

implement tsrm_is_shutdown API

Use the portable zend_strndup() instead of strndup()

Fix phpdbg shutdown order

In particular, make sure that everything using zmm is released
before zmm is shut down. phpdbg currently gets away with this,
because either a) its custom h

Fix phpdbg shutdown order

In particular, make sure that everything using zmm is released
before zmm is shut down. phpdbg currently gets away with this,
because either a) its custom handlers are used and no auto-free
happens or b) the system allocator is used and no auto-free happens.
With the tracking allocator for asan this no longer works.

show more ...

Don't use zmm for PHPDBG_G(exec)

Uses system allocator when backing up settings ... let's avoid
unnecessary confusion.

Fix prompt leak in phpdbg

Register class before fetching parent

We want the class declaration to be available while compiling the
parent class.

Fix potentially uninitialized warnings in phpdbg

Implemented a faster way to access predefined TSRM resources - CG(), EG(), etc.

Avoid reinitailization of ZTS cache pointer. Initialize it once in TSRM.c

Use TSRM macros

Update and fix remaining year ranges (2019)

This patch follows previous license year ranges updates. With new
approach source code files now have simplified headers with license
info

Update and fix remaining year ranges (2019)

This patch follows previous license year ranges updates. With new
approach source code files now have simplified headers with license
information without year ranges.

show more ...

Remove yearly range from copyright notice

Don't wrap php_module_shutdown() with zend_try. executor_globals are released in ZTS build, and this leads to crash.

Trim trailing whitespace in source code files

Trim trailing whitespace in source code files

Keep information about unresolved interfaces in zend_class_entry->interface_names.
Move interface implementation code into ZEND_DECLARE_*CLASS opcodes.
Remove ZEND_ADD_INTERFACE and ZEND_VER

Keep information about unresolved interfaces in zend_class_entry->interface_names.
Move interface implementation code into ZEND_DECLARE_*CLASS opcodes.
Remove ZEND_ADD_INTERFACE and ZEND_VERIFY_ABSTRACT_CLASS opcodes.

show more ...

Replace zend_class_entry->traits by persistent zend_class_entry->trait_names.
Move trait binding code into ZEND_DECLARE_*CLASS opcodes.
Remove ZEND_ADD_TRIAIT and ZEND_BIND_TRAITS opcodes.

Pack zend_constant.flags and zend_constant.module_number into reserved space inside zend_constant.value.

Remove duplicated code (keep destroy_zend_function() for compatibility)