Fix leak when setting cyclic previous exception in finally

A curious exception handling pattern found in Symfony's HttpClient.

Fixed bug #79536 (zend_clear_exception prevent exception's destructor to be called).

Remove redundant variable rv and optimize code

Closes GH-4864.

simple ignore arguments in exceptions implementation

Fix assertion in Exception::getMessage() if $message is a ref

And same for other properties. Encountered in Symfony.

Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly

Remove local variables

This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly used by Vim and Emacs editors
yet with recent changes the once working definitions don't work
anymore in Vim without custom plugins or additional configuration.
Neither are these settings synced across the PHP code base.

A simpler and better approach is EditorConfig and fixing code
using some code style fixing tools in the future instead.

This patch also removes the so called modelines for Vim. Modelines
allow Vim editor specifically to set some editor configuration such as
syntax highlighting, indentation style and tab width to be set in the
first line or the last 5 lines per file basis. Since the php test
files have syntax highlighting already set in most editors properly and
EditorConfig takes care of the indentation settings, this patch removes
these as well for the Vim 6.0 and newer versions.

With the removal of local variables for certain editors such as
Emacs and Vim, the footer is also probably not needed anymore when
creating extensions using ext_skel.php script.

Additionally, Vim modelines for setting php syntax and some editor
settings has been removed from some *.phpt files. All these are
mostly not relevant for phpt files neither work properly in the
middle of the file.

show more ...

Adios, yearly copyright ranges

Revert removal of private __clone() methods

I thought these were redundant, because we already NULL out the
clone_obj object handler. However, it turns out that reflection is
using p

Revert removal of private __clone() methods

I thought these were redundant, because we already NULL out the
clone_obj object handler. However, it turns out that reflection is
using private __clone() to determine clonability (isCloneable) for
the case where we only have a class, rather than an object.

As such, removing these methods would be a BC break.

This reverts commit e7131a4e9fa0acf8fc1e486b49851e71859ef5b8.
This reverts commit 55bd88ce0d1bf461546d5d0b40920491d566ed48.

show more ...

Remove redundant Exception::__clone() method

Exceptions already prohibit cloning by setting clone_obj to NULL
(which is integrated with reflection). No need to additionally
define a

Remove redundant Exception::__clone() method

Exceptions already prohibit cloning by setting clone_obj to NULL
(which is integrated with reflection). No need to additionally
define a dummy __clone() method.

show more ...

Use ZEND_THIS macro to hide implementation details in extensions code.

Replace getThis() by EX(This), when additional check is not necessary.

Future-proof email addresses

Update email addresses. We're still @Zend, but future proofing it...

Fix some misspellings

Remove unused Git attributes ident

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
use

Remove unused Git attributes ident

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
user who changed it.

In Git this functionality is different and can be done with Git attribute
ident. These need to be defined manually for each file in the
.gitattributes file and are afterwards replaced with 40-character
hexadecimal blob object name which is based only on the particular file
contents.

This patch simplifies handling of $Id$ keywords by removing them since
they are not used anymore.

show more ...

Avoid magic method hash lookups

Fixed bug #76502

Fixed bug #75218

I've introduced a new CompileError type, from which ParseError
inherits. These errors are not parse errors in the narrow sense
of the term, even though they happen t

Fixed bug #75218

I've introduced a new CompileError type, from which ParseError
inherits. These errors are not parse errors in the narrow sense
of the term, even though they happen to be generated during
parsing in our implementation. Additionally reusing the ParseError
class for this purpose would change existing error messages (if
the exception is not caught) from a "Fatal error:" to a "Parse
error:" prefix, and also the error kind from E_COMPILE_ERROR to
E_PARSE.

show more ...

Export standard object handlers, to avoid indirect access

Use zend_string_release_ex() instread of zend_string_release() in places, where we sure about string persistence.

Use reference counting instead of duplication

Revert "[ci skip] Add missing return types to protos"

This reverts commit a2c7c46d5ef5b9fc945d7b655d31d5c9f1a72d34.

Since apparently there have been some mistakes in this commit, an

Revert "[ci skip] Add missing return types to protos"

This reverts commit a2c7c46d5ef5b9fc945d7b655d31d5c9f1a72d34.

Since apparently there have been some mistakes in this commit, and it's
not clear yet how to solve them, we're reverting for now.

show more ...

[ci skip] Add missing return types to protos

year++

year++