#
16c7c716 |
| 17-Feb-2020 |
Christoph M. Becker |
Fix NEWS [ci skip]
|
#
5009b981 |
| 17-Feb-2020 |
Christoph M. Becker |
Update NEWS [ci skip]
|
#
09669411 |
| 14-Feb-2020 |
Christoph M. Becker |
Fix #79271: DOMDocumentType::$childNodes is NULL Dom level 2 core, DOM level 3 core and the DOM living standard agree that `childNodes` always return a `NodeList`, and never `null`.
|
#
8308196c |
| 14-Feb-2020 |
Christoph M. Becker |
Fix typo in recent bugfix
|
#
cec8b24c |
| 13-Feb-2020 |
Christoph M. Becker |
Fix #77569: Write Acess Violation in DomImplementation We must not assume that the zval IS_STRING.
|
#
3a515309 |
| 11-Feb-2020 |
Nikita Popov |
Fixed bug #79257 Replace an existing entry for a given name only if we have a match.
|
#
7b464ce6 |
| 11-Feb-2020 |
Christoph M. Becker |
Fix #79254: getenv() w/o arguments not showing changes To be able to see changes done only with `SetEnvironmentVariable()`, we have to use `GetEnvironmentStrings()` instead of `environ`,
Fix #79254: getenv() w/o arguments not showing changes To be able to see changes done only with `SetEnvironmentVariable()`, we have to use `GetEnvironmentStrings()` instead of `environ`, because the latter sees only changes done with `putenv()`. For best backward compatibility we're using `GetEnvironmentStringsA()`; switching to the wide string version likely makes sense for master, though.
show more ...
|
#
6295ff77 |
| 10-Feb-2020 |
Xinchen Hui |
Fixed bug #79244 (php crashes during parsing INI file). (Laruence) Cherry-picked the fix(not sure why this wasn't merged to 7.4) for: Fixed bug #77589 (Core dump using parse_ini_string w
Fixed bug #79244 (php crashes during parsing INI file). (Laruence) Cherry-picked the fix(not sure why this wasn't merged to 7.4) for: Fixed bug #77589 (Core dump using parse_ini_string with numeric sections) Section name should not be typed(NULL, FALSE, TRUE etc) Conflicts: Zend/zend_ini_scanner.c
show more ...
|
#
f649aded |
| 08-Feb-2020 |
Christoph M. Becker |
Fix #79248: Traversing empty VT_ARRAY throws com_exception If the `VT_ARRAY` is empty, i.e. its upperbound is less than its lower bound, we must not call `php_com_safearray_get_elem()`,
Fix #79248: Traversing empty VT_ARRAY throws com_exception If the `VT_ARRAY` is empty, i.e. its upperbound is less than its lower bound, we must not call `php_com_safearray_get_elem()`, because that function throws in this case.
show more ...
|
#
b4f61d99 |
| 08-Feb-2020 |
Christoph M. Becker |
Fix #79247: Garbage collecting variant objects segfaults variant objects have no (declared) properties, so the `get_properties` handlers returns a pointer to constant storage for efficie
Fix #79247: Garbage collecting variant objects segfaults variant objects have no (declared) properties, so the `get_properties` handlers returns a pointer to constant storage for efficiency reasons. This pointer must not be returned from the `get_gc` handler, though; instead we set up an own `get_gc` handler and return NULL from it, to signal that there are no properties to collect.
show more ...
|
#
b9738f58 |
| 07-Feb-2020 |
Christoph M. Becker |
Fix #79242: COM error constants don't match com_exception codes Because a `HRESULT` is a `LONG`[1], no special treatment is required on x86 platforms to get appropriate values. On x64 p
Fix #79242: COM error constants don't match com_exception codes Because a `HRESULT` is a `LONG`[1], no special treatment is required on x86 platforms to get appropriate values. On x64 platforms we prefer positive values, what we could accomplish by casting the `HRESULT` value to `ULONG` and then to `zend_long`, but since the current behavior is correct and the performance improvement is negligible, we defer that to master. [1] <https://docs.microsoft.com/en-us/windows/win32/winprog/windows-data-types#hresult>
show more ...
|
#
cd5591a2 |
| 07-Feb-2020 |
Nikita Popov |
PCRE: Only remember valid UTF-8 if start offset zero PCRE only validates the string starting from the start offset (minus maximum look-behind, but let's ignore that), so we can only
PCRE: Only remember valid UTF-8 if start offset zero PCRE only validates the string starting from the start offset (minus maximum look-behind, but let's ignore that), so we can only remember that the string is fully valid UTF-8 is the original start offset is zero.
show more ...
|
#
5e2ea00b |
| 06-Feb-2020 |
Christoph M. Becker |
Fix #66322: COMPersistHelper::SaveToFile can save to wrong location Saving under the given `filename` may also work, but since `::LoadFromFile` uses the `fullpath` we follow suit.
|
#
1cffc7b9 |
| 06-Feb-2020 |
Christoph M. Becker |
Fix NEWS [ci skip] This bugfix didn't make it into 7.4.3.
|
#
13bfa9f5 |
| 29-Jan-2020 |
Nikita Popov |
Fixed bug #79188
|
#
e3632fdc |
| 04-Feb-2020 |
Christoph M. Becker |
Next is 7.3.16
|
#
2d0dec91 |
| 04-Feb-2020 |
Christoph M. Becker |
Fix #79019: Copied cURL handles upload empty file To cater to `curl_copy_handle()` of cURL handles with attached `CURLFile`s, we must not attach the opened stream, because the stream
Fix #79019: Copied cURL handles upload empty file To cater to `curl_copy_handle()` of cURL handles with attached `CURLFile`s, we must not attach the opened stream, because the stream may not be seekable, so that we could rewind, when the same stream is going to be uploaded multiple times. Instead, we're opening the stream lazily in the read callback. Since `curl_multi_perfom()` processes easy handles asynchronously, we have no control of the operation sequence. Since duplicated cURL handles may be used with multi handles, we cannot use a single arg structure, but actually have to rebuild the whole mime structure on handle duplication and attach this to the new handle. In order to better test this behavior, we extend the test responder to print the size of the upload, and patch the existing tests accordingly.
show more ...
|
#
079905ac |
| 03-Feb-2020 |
Christoph M. Becker |
Fix #78090: bug45161.phpt takes forever to finish Not all systems support the discard protocol (TCP port 9), and since there is no particular reason to use it, we switch to using actual
Fix #78090: bug45161.phpt takes forever to finish Not all systems support the discard protocol (TCP port 9), and since there is no particular reason to use it, we switch to using actual server testing.
show more ...
|
#
fe1bfb78 |
| 03-Feb-2020 |
Christoph M. Becker |
Fix #79191: Error in SoapClient ctor disables DOMDocument::save() The culprit is the too restrictive fix for bug #71536, which prevents `php_libxml_streams_IO_write()` from properly exec
Fix #79191: Error in SoapClient ctor disables DOMDocument::save() The culprit is the too restrictive fix for bug #71536, which prevents `php_libxml_streams_IO_write()` from properly executing when unclean shutdown is flagged. A *more* suitable solution is to move the `xmlwriter_free_resource_ptr()` call from the `free_obj` handler to an added `dtor_obj` handler, to avoid to write to a closed stream in case of late object freeing. This makes the `EG(active)` guard superfluous. We also fix bug79029.phpt which has to use different variables for the three parts to actually check the original shutdown issue. Thanks to bwoebi and daverandom for helping to investigate this issue.
show more ...
|
#
c2935499 |
| 02-Feb-2020 |
Christoph M. Becker |
Fix #79212: NumberFormatter::format() may detect wrong type We have to convert to number *before* detecting the type, to cater to internal objects implementing `cast_object`. We
Fix #79212: NumberFormatter::format() may detect wrong type We have to convert to number *before* detecting the type, to cater to internal objects implementing `cast_object`. We also get rid of the fallback behavior of using `FORMAT_TYPE_INT32`, because that can no longer happen; after `convert_scalar_to_number_ex` the type is either `IS_LONG` or `IS_DOUBLE`. We cater explicitly to the `IS_ARRAY` case what also avoids triggering a type confusion when `::TYPE_INT64` is passed as `$type`.
show more ...
|
#
846e52bd |
| 03-Feb-2020 |
Remi Collet |
NEWS
|
#
ef1e4891 |
| 31-Jan-2020 |
Nikita Popov |
Fix bug #76047 Unlink the current stack frame before freeing CVs or extra args. This means it will no longer show up in back traces that are generated during CV destruction.
Fix bug #76047 Unlink the current stack frame before freeing CVs or extra args. This means it will no longer show up in back traces that are generated during CV destruction. We already did this prior to destructing the object/closure, presumably for the same reason.
show more ...
|
#
f70b5523 |
| 30-Jan-2020 |
Nikita Popov |
Fixed bug #79193
|
#
8226e704 |
| 29-Jan-2020 |
Christoph M. Becker |
Fix #70078: XSL callbacks with nodes as parameter leak memory The fix for bug #49634 solved a double-free by copying the node with `xmlDocCopyNodeList()`, but the copied node is later fr
Fix #70078: XSL callbacks with nodes as parameter leak memory The fix for bug #49634 solved a double-free by copying the node with `xmlDocCopyNodeList()`, but the copied node is later freed by calling `xmlFreeNode()` instead of `xmlFreeNodeList()`, thus leaking memory. However, there is no need to treat the node as node list, i.e. to copy also the node's siblings; just creating a recursive copy of the node with `xmlDocCopyNode()` is sufficient, while that also avoids the leak.
show more ...
|
#
bdcfdd44 |
| 29-Jan-2020 |
Remi Collet |
zip: more constants
|