Fix #66005: imagecopy does not support 1bit transparency on truecolor images

We must not copy transparent pixels, see
<https://github.com/libgd/libgd/commit/daac285c>.

#72482, revert for 5.6 for now

Fix #43828: broken transparency of imagearc for truecolor in blendingmode

No pixel of a filled arc must ever be drawn multiple times. Otherwise we get
artifacts regarding transparency. T

Fix #43828: broken transparency of imagearc for truecolor in blendingmode

No pixel of a filled arc must ever be drawn multiple times. Otherwise we get
artifacts regarding transparency. That happens with the current
implementation of gdImageFilledArc() unless gdChord or gdNoFill are set.
When gdPie is set, however, the filled arc is drawn in wedges, which are
polygons of three points, and so some overlap is natural.

To resolve the issue, we stick with the current algorithm of calculating the
wedges, but instead of drawing each polygon separately, we put the relevant
points in a large array, and draw a single polygon. That also is supposed to
improve the performance considerably.

Note that this modification will change the results when gdImageSetStyle()
or gdImageSetBrush() are used, but we believe that this modification is also
an improvement in this regard, even though it still might not make much
sense to use these functions with gdImageFilledArc().

The respective fix for libgd is
<https://github.com/libgd/libgd/commit/e7e20d6>.

show more ...

#72482, Ilegal write/read access caused by gdImageAALine overflow

fix #72512, invalid read or write for palette image when invalid transparent index is used

Conflicts:
ext/gd/libgd/gd.c

fix #72512, invalid read or write for palette image when invalid transparent index is used

Fix for bug #72558, Integer overflow error within _gdContributionsAlloc()

Fix #72604: imagearc() ignores thickness for full arcs

We remove the special casing for full arcs, what conforms to external libgd.

Fixed bug #72512 gdImageTrueColorToPaletteBody allows arbitrary write/read access

iFixed bug #72446 - Integer Overflow in gdImagePaletteToTrueColor() resulting in heap overflow

Fix #64641: imagefilledpolygon doesn't draw horizontal line

As has been reported, 1-dimensional horizontal filled polygons are not drawn
at all. That is caused by the scanline algorithm

Fix #64641: imagefilledpolygon doesn't draw horizontal line

As has been reported, 1-dimensional horizontal filled polygons are not drawn
at all. That is caused by the scanline algorithm used for drawing filled
polygons which skips the drawing of horizontal edges, because that is
normally not necessary. If, however, the polygon consists of horizontal
edges only, that obviously doesn't work, so we add a special case handling.

That has also been fixed in libgd with
<https://github.com/libgd/libgd/commit/f9f10fa9>.

show more ...

Fix #43475: Styled thick horizontal lines are scrambled

Thick lines are drawn by gdImageFilledRectangle(), which iterates over
the x ordinate first (Z order) to apply the style pattern.

Fix #43475: Styled thick horizontal lines are scrambled

Thick lines are drawn by gdImageFilledRectangle(), which iterates over
the x ordinate first (Z order) to apply the style pattern. While this works
fine for vertical and diagonal lines, it obviously fails for horizontal
lines, which have to be iterated over in N order.

To fix this bug, we introduce the helpers gdImageFilled(H|V)Rectangle(),
which may be reused for other purposes as well.

This is basically the same fix as libgd/libgd/c2b91dbc.

show more ...

Fix #66387: Stack overflow with imagefilltoborder

The stack overflow is caused by the recursive algorithm in combination with a
very large negative coordinate passed to gdImageFillToBord

Fix #66387: Stack overflow with imagefilltoborder

The stack overflow is caused by the recursive algorithm in combination with a
very large negative coordinate passed to gdImageFillToBorder(). As there is
already a clipping for large positive coordinates to the width and height of
the image, it seems to be consequent to clip to zero also.

show more ...

prevent invalid color index (palette only), may lead to crash

Fix #66387: Stack overflow with imagefilltoborder

The stack overflow is caused by the recursive algorithm in combination with a
very large negative coordinate passed to gdImageFillToBord

Fix #66387: Stack overflow with imagefilltoborder

The stack overflow is caused by the recursive algorithm in combination with a
very large negative coordinate passed to gdImageFillToBorder(). As there is
already a clipping for large positive coordinates to the width and height of
the image, it seems to be consequent to clip to zero also.

show more ...

Fix #53156: imagerectangle problem with point ordering

Contrary to imagefilledrectangle(), imagerectangle() has the documented
limitation that the given points have to be the upper left

Fix #53156: imagerectangle problem with point ordering

Contrary to imagefilledrectangle(), imagerectangle() has the documented
limitation that the given points have to be the upper left and the lower right
corner, respectively. However, libgd already caters to upper right / lower left
pairs, and not catering to the other two combinations seems to be an oversight.

show more ...

Fix #53154: Zero-height rectangle has whiskers

To avoid drawing the corner pixels twice, gdImageRectangle() draws the vertical
lines 2 points shorter than the actual side of the rectangl

Fix #53154: Zero-height rectangle has whiskers

To avoid drawing the corner pixels twice, gdImageRectangle() draws the vertical
lines 2 points shorter than the actual side of the rectangle. However, this
causes "whiskers" for rectangles with height 0. This patch fixes this issue and
at the same time optimizes the algorithm by drawing only a single line for zero
height and zero width rectangles.

show more ...

trailing whitespace removal

fix memory leak

Fix Bug #68713 infinite loop / infinite free

PHP not affected (emalloc never return NULL)
Just to reduce diff with upstream and for legibility

Apply:
https://bitbucket.org/

Fix Bug #68713 infinite loop / infinite free

PHP not affected (emalloc never return NULL)
Just to reduce diff with upstream and for legibility

Apply:
https://bitbucket.org/libgd/gd-libgd/commits/3c0d2203b2672b688d4d2326ff3a60b019879062
https://bitbucket.org/libgd/gd-libgd/commits/4af76c97a478d4e7c4b64e08ac67abbca7cbd0fb

show more ...

first shot remove TSRMLS_* things

bring back all the TSRMLS_FETCH() stuff

for better comparability with the mainstream

cleanup TSRMLS_FETCH in ext/gd

Reduce compiler noise by removing unused variables and labels

fix #65070, bgcolor does not use the same format as the input image with imagerotate