Always throw TypeException on throwing zpp failures

Introduces a ZEND_PARSE_PARAMS_THROW flag for zpp, which forces to
report FAILURE errors using a TypeException instead of a Warning,

Always throw TypeException on throwing zpp failures

Introduces a ZEND_PARSE_PARAMS_THROW flag for zpp, which forces to
report FAILURE errors using a TypeException instead of a Warning,
like it would happen in strict mode.

Adds a zend_parse_parameters_throw() convenience function, which
invokes zpp with this flag.

Converts all cases I could identify, where we currently have
throwing zpp usage in constructors and replaces them with this API.
Error handling is still replaced to EH_THROW in some cases to handle
other, domain-specific errors in constructors.

show more ...

Clarify that some zpp errors are just for debugging

These occur when the extension author messed up, not during normal
script execution.

Make these core errors and show them eve

Clarify that some zpp errors are just for debugging

These occur when the extension author messed up, not during normal
script execution.

Make these core errors and show them even with PARAMS_QUIET.

show more ...

Convert fatal errors into EngineException

Fixed performance degradation introduced with lateast EnfineException related changes.
Restore original errors order in executor.

Convert fatal errors into EngineExceptions
Make zval_update_constant_ex(), zval_update_constant(), zend_update_class_constants() and zend_ast_evaluate() return SUCCESS or FAILURE.

Convert fatal errors into EngineExceptions

Convert fatal errors into EngineExceptions

Use zend_error_noreturn() for fatal errors

Drop support for static calls from incompatible context

Implemented by NULLing $this.

Reclassify E_STRICT notices

Per RFC https://wiki.php.net/rfc/reclassify_e_strict

While reviewing this, found that there are still three E_STRICTs
left in libraries - need to dis

Reclassify E_STRICT notices

Per RFC https://wiki.php.net/rfc/reclassify_e_strict

While reviewing this, found that there are still three E_STRICTs
left in libraries - need to discuss those.

show more ...

Patch improvement:

Removed the corresponding core code.
Fixed ext/com_dotnet and ext/date.
Refactored ext/intl changes.
Improved ext/fileinfo and ext/pdo changes.
Fixed tests.

Constness to zend_get_object_type(), thanks Michael!

Change "Cannot redeclare class X" into "Cannot redeclare class/interface/trait X", meaning that the following:

C:\> php -r "trait A { } trait A { }"

Will now properly print "Cannot

Change "Cannot redeclare class X" into "Cannot redeclare class/interface/trait X", meaning that the following:

C:\> php -r "trait A { } trait A { }"

Will now properly print "Cannot redeclare trait A" instead of "Cannot redeclare class A" to make error messages a tiny bit clearer. Admittedly, a better solution can most likely be made by actually telling what the colliding object is a type of.

Internally this adds a new function:
zend_get_object_type()

show more ...

Partially revert "Fix uninitialized value condition"

This reverts commit e874f76096a346c5ee073c8aaf252d916f3be925,
which broke zpp quite mode.

Only the initialization of the "se

Partially revert "Fix uninitialized value condition"

This reverts commit e874f76096a346c5ee073c8aaf252d916f3be925,
which broke zpp quite mode.

Only the initialization of the "severity" variable is retained.

show more ...

Fix uninitialized value condition

ZPP changed to lazely check for "strict/weak" only if it's really necessary.
Cleanup.

Improved type hinting:

EX_PREV_USES_STRICT_TYPES() and family changed/renamed to fit with other macros
Optimized zend_verify_internal_arg_type() and family (they don't need "strict" argu

Improved type hinting:

EX_PREV_USES_STRICT_TYPES() and family changed/renamed to fit with other macros
Optimized zend_verify_internal_arg_type() and family (they don't need "strict" argument anymore)
Standerd ZPP is called from VM only for weak type check or strict exception (int -> double)
Fixed ZEND_RECV_VARIADIC
Fixed ZEND_STRLEN

TODO: should we accept IS_NULL for non-nullable arguments?

show more ...

Fixed white spaces

Refactor as to not use call info, but add the flag to the op_array.

Fix severity issues with callbacks, start work porting ZEND_STRLEN opcode to work with strict mode, more refactoring to come

Fix C89 compatibility by moving a misplaced if statement

Style cleanup, as well as fixing bug with missing argument for WRONG_PARAM_COUNT_WITH_RETVAL

Clean up API renames for zend_wrong_param_count to maintain BC, introducing a zend_wrong_param_count_ex() function when you know strict value

Refactor error implementation significantly to centralize error mode behavior. Add zend_internal_type_error() function

Remove wrong commit committed by accident