Fix bug #71529

Forbid double use() and use() of param

Also commit a test I forgot to add for forbidden use() of
auto-globals.

Introduced BIND_STATIC opcode instead of FETCH_R/FETCH_W(static)+ASSIGN/ASSIGN_REF (similar to BIND_GLOBAL).
In the future we may refer to static variable by index instead of name, to eliminate h

Introduced BIND_STATIC opcode instead of FETCH_R/FETCH_W(static)+ASSIGN/ASSIGN_REF (similar to BIND_GLOBAL).
In the future we may refer to static variable by index instead of name, to eliminate hash lookup.

show more ...

Fixed bug #71300 (Segfault in zend_fetch_string_offset)

bump year which is missed in rev 49493a2

bump year which is missed in rev 49493a2

MFH: Fix lineno for finally FAST_CALL and JMP

Fix lineno for finally FAST_CALL and JMP

Introduce BIND_LEXICAL

This opcodes inserts a local CV into the closure static variable
table. This replaces the previous mechanism of having static
variables marked as LEXICAL, whic

Introduce BIND_LEXICAL

This opcodes inserts a local CV into the closure static variable
table. This replaces the previous mechanism of having static
variables marked as LEXICAL, which perform a symtable lookup
during copying.

This means a) functions which contain closures no longer have to
rebuild their symtable (better performance) and b) we can now track
used variables in SSA.

show more ...

Forbid use() of auto-globals

We don't correctly support it, it doesn't make sense and it's also
forbidden for parameters.

Remove mentions of "type hint" and "typehint"

Fixed bug #71196 (Memory leak with out-of-order live ranges)

Remove uses of VARs in extended_value

The DECLARE_(ANON_)INHERITED_CLASS(_DELAYED) opcodes were
referencing the parent ce VAR through extended_value. This is
hacky and we can't track

Remove uses of VARs in extended_value

The DECLARE_(ANON_)INHERITED_CLASS(_DELAYED) opcodes were
referencing the parent ce VAR through extended_value. This is
hacky and we can't track the def-use chain in SSA.

To avoid this, the layout of declaration opcodes is changed
as follows: op1 points to the lcname and rtd_key literals, in
that order. (For anon/lambda declarations only one of lcname or
rtd_key is present.) This frees up op2, which is now used to
reference the parent ce VAR in inheriting declarations. The
jmp offset for anon class declarations is moved frop op2 to
extended_value.

The changes were applied both to class and function declarations
to keep everything symmetric.

show more ...

Fix bug #70804

This follows on from a4648ded430985e019b446939c4ff5bef36c0b91 and
4e01269082d20f5598c481f122b3eea10a586e2b.
Both -(+0.0) and +(-0.0) behaved incorrectly for the same r

Fix bug #70804

This follows on from a4648ded430985e019b446939c4ff5bef36c0b91 and
4e01269082d20f5598c481f122b3eea10a586e2b.
Both -(+0.0) and +(-0.0) behaved incorrectly for the same reason.

show more ...

Fix bug #52355

Use FETCH_CLASS_EXCEPTION for instanceof

This does not collide with NO_AUTOLOAD -- missing classes will be
silenced, but invalid use of self etc will result in an exception
instead o

Use FETCH_CLASS_EXCEPTION for instanceof

This does not collide with NO_AUTOLOAD -- missing classes will be
silenced, but invalid use of self etc will result in an exception
instead of a fatal error.

show more ...

Add result op for ASSERT_CHECK to fix SSA

Otherwise one source of the phi node at the join point will be
borked.

I'm marking the ASSERT_CHECK result as unused in pass2, which is

Add result op for ASSERT_CHECK to fix SSA

Otherwise one source of the phi node at the join point will be
borked.

I'm marking the ASSERT_CHECK result as unused in pass2, which is
a bit ugly.

show more ...

Fixed bug #71092 (Segmentation fault with return type hinting)

Remove BP_VAR_REF

The distinction between BP_VAR_REF and BP_VAR_W is no longer
revelant, since we dropped support for =& new.

Make duplicate class constant error for internal class

And drop two duplicate constant declarations from intl. These
were leaking previously.

Make ZEND_CLONE return a TMP_VAR

As the return value can't be reference and it's unlikely to be
unused.

Also remove some unnecessary checks for ce==NULL. A ce is required
no

Make ZEND_CLONE return a TMP_VAR

As the return value can't be reference and it's unlikely to be
unused.

Also remove some unnecessary checks for ce==NULL. A ce is required
nowadays.

show more ...

Drop two compiler TODOs

Call-time pass by reference is now a parse error.
There is no benefit in dropping implementing_class currently.

Reintroduce use of FETCH_GLOBAL_LOCK

Just found this old AST todo...

It no longer makes sense as an optimization due to the introduction
of BIND_GLOBAL, however it ensures that

Reintroduce use of FETCH_GLOBAL_LOCK

Just found this old AST todo...

It no longer makes sense as an optimization due to the introduction
of BIND_GLOBAL, however it ensures that the global variable name is
not evaluated twice, which is presumably something we wish to
guarantee.

show more ...

Remove FETCH_STATIC_MEMBER flag

Fix Foo::${42} and similar

Fixes segfault on direct use, segfault on opcache evaluated use,
leak on temporary use.

Fixes analogeous segfault for ${42} on opcache eval as well.